Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logo too big #132

Merged
merged 1 commit into from
Aug 20, 2024
Merged

logo too big #132

merged 1 commit into from
Aug 20, 2024

Conversation

ryansurf
Copy link
Owner

@ryansurf ryansurf commented Aug 20, 2024 •
edited by sourcery-ai bot
Loading

General:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Code:

  1. Does your submission pass tests?
  2. Have you run the linter/formatter on your code locally before submission?
  3. Have you updated the documentation/README to reflect your changes, as applicable?
  4. Have you added an explanation of what your changes do?
  5. Have you written new tests for your changes, as applicable?

Summary by Sourcery

Adjust the logo size in the README to enhance visual consistency by reducing its maximum height.

Documentation:

  • Reduce the maximum height of the logo in the README from 240px to 150px to improve visual presentation.

@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented Aug 20, 2024 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request modifies the README.md file to reduce the maximum height of the logo image from 240px to 150px. The change is implemented by updating the inline CSS style attribute of the img tag.

File-Level Changes

Files Changes
README.md Reduced the maximum height of the logo image from 240px to 150px
Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@ryansurf ryansurf merged commit a4e640b into main Aug 20, 2024
9 checks passed
sourcery-ai[bot]
sourcery-ai bot reviewed Aug 20, 2024
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ryansurf - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Ensure that the checklist in the pull request description is completed to confirm that all contribution guidelines have been followed.
  • Verify that the README and any other relevant documentation are up to date with this change.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ryansurf